fix(sandbox): rotate openshell.log daily, keep 3 files by Kh4L · Pull Request #431 · NVIDIA/OpenShell

Kh4L · 2026-03-18T08:13:53Z

Summary

Replaces the unbounded append-only /var/log/openshell.log with a RollingFileAppender that rotates daily and retains at most 3 files
No new dependencies — tracing-appender is already a workspace dependency in openshell-sandbox
Falls back to stdout-only logging if /var/log is not writable (existing behavior preserved)

Related Issue

Closes #30

Changes

crates/openshell-sandbox/src/main.rs: replace std::fs::OpenOptions + non_blocking(file) with RollingFileAppender::builder() configured for daily rotation and a 3-file cap

Testing

mise run test passes
Sandbox logs appear as /var/log/openshell.YYYY-MM-DD.log inside a running sandbox
Old log files beyond the 3-file limit are pruned on rotation

Checklist

Follows Conventional Commits format
Signed-off-by line included (git commit -s)
No new dependencies introduced

Replace unbounded append-only log with a RollingFileAppender (daily rotation, max 3 files). tracing-appender is already a workspace dependency so no new crates are needed. Closes NVIDIA#30 Signed-off-by: Serge Panev <spanev@nvidia.com>

github-actions · 2026-03-18T08:14:03Z

Thank you for your interest in contributing to OpenShell, @Kh4L.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

Open a Vouch Request discussion.
Describe what you want to change and why.
Write in your own words — do not have an AI generate the request.
A maintainer will comment /vouch if approved.
Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

johntmyers · 2026-03-18T15:35:16Z

Reopening — you were incorrectly closed by the vouch gate. The workflow couldn't verify your NVIDIA org membership due to a GITHUB_TOKEN permissions issue. Fix is in #442.

github-actions · 2026-03-18T15:35:30Z

Thank you for your interest in contributing to OpenShell, @Kh4L.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

Open a Vouch Request discussion.
Describe what you want to change and why.
Write in your own words — do not have an AI generate the request.
A maintainer will comment /vouch if approved.
Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

johntmyers · 2026-03-18T16:06:46Z

Reopening now that #442 has merged. The vouch gate will now check author_association from the webhook payload, which correctly identifies you as an NVIDIA org member.

github-actions · 2026-03-18T16:07:00Z

Thank you for your interest in contributing to OpenShell, @Kh4L.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

Open a Vouch Request discussion.
Describe what you want to change and why.
Write in your own words — do not have an AI generate the request.
A maintainer will comment /vouch if approved.
Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

johntmyers · 2026-03-18T16:15:51Z

Reopening — the vouch gate now fetches author_association via the REST API (#444), which correctly identifies you as an NVIDIA org member. Sorry for the repeated closures!

github-actions · 2026-03-18T16:16:02Z

Thank you for your interest in contributing to OpenShell, @Kh4L.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

Open a Vouch Request discussion.
Describe what you want to change and why.
Write in your own words — do not have an AI generate the request.
A maintainer will comment /vouch if approved.
Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

The rolling file appender introduced in PR #431 writes date-stamped files (openshell.YYYY-MM-DD.log) instead of a single openshell.log. Update _read_openshell_log() and _verify_sandbox_functional() to glob for all matching log files so the tests work with both layouts. Signed-off-by: Drew Newberry <anewberry@nvidia.com>

Kh4L requested a review from a team as a code owner March 18, 2026 08:13

github-actions bot closed this Mar 18, 2026